pgsql/src/interfaces/jdbc/org/postgresql jdbc1 ...

CVSROOT:    /home/projects/pgsql/cvsroot
Module name:    pgsql
Changes by:    momjian@hub.org    01/08/17 09:59:29

Modified files:
    src/interfaces/jdbc/org/postgresql/jdbc1: DatabaseMetaData.java
    src/interfaces/jdbc/org/postgresql/jdbc2: DatabaseMetaData.java

Log message:
    Attached is the patch requested by Tom Lane (see below). It
    includes two changes in the JDBC driver:

    1) When connected to a backend >= 7.2: use obj_description() and
    col_description() instead of direct access to pg_description.

    2) In DatabaseMetaData.getTables()/getColumns()/getProcedures():
    when there is no comment on the object, return null in the
    REMARKS column of the ResultSet, instead of the default string
    "no remarks".

    Change 2 first appeared as a side-effect of change 1, but it is
    actually more compliant with the JDBC spec: "String object
    containing an explanatory comment on the table/column/procedure,
    which may be null". The default string "no remarks" was strictly
    speaking incorrect, as it could not be distinguished from a real
    user comment "no remarks". So I removed the default string
    completely.

    Change 2 might break existing code that doesn't follow the JDBC
    spec and isn't prepared to handle a null in the REMARKS column
    of getTables()/getColumns()/getProcedures.

    Patch tested with jdbc2 against both a 7.1 and a CVS tip
    backend. I did not have a jdbc1 environment to build and test
    with, but since the touched code is identical in jdbc1 and jdbc2
    I don't foresee any problems.

    Regards,
    Ren? Pijlman