Re: pgsql/src/bin/pg_ctl pg_ctl.sh

> I wrote:
>
> > >     Move export PGDATA to the proper place.
> >
> > This is completely broken.  The old place was right.
>
> Correction:  The new place also seems to be okay, but 'export VAR=stuff'
> is not portable,  You need to split it into two commands.

Oh, yes you are totally correct.  I am forgetting my old shell stuff.

>
> > > Quote some variable substitutions.
> >
> > You don't need to quote the argument to 'case'.  Please don't do that, it
> > makes things less readable.
>
> Also, you don't need to quote the right side of
>
> FOO=$BAR

That is interesting.  I just tried:

    #$ X="1 2"
    #$ Y=$X
    #$ echo $X
    1 2

When do I need quotes around variables then?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026