Re: [current] readline breakage

Peter,

[This may not make it to pgsql-hackers since I'm not subscribed, feel
free to forward it on my behalf...]

On Sat, Jun 16, 2001 at 06:51:59PM +0200, Peter Eisentraut wrote:
> Alex Pilosov writes:
> 
> > > > tab-complete.c: In function `psql_completion':
> > > > tab-complete.c:754: `filename_completion_function' undeclared (first use
> > > > in this function)
> 
> > Yeah, sorry, my fault. OpenBSD 2.8 ships with a broken readline (dated
> > 1996). 2.9 has a recent GNU readline. I don't think its worth supporting
> > 2.8 readline either, but I forgot to check the archives.
> 
> We used to declare filename_completion_function explicitly, but it seems
> to have been removed recently by a Cygwin-related patch from Jason
> Tishler.  Jason, was this required to work on Cygwin or was it merely a
> "cleaning up" issue?

Yes, this change is required under Cygwin when building against
readline 4.2.  Note that my patch is modeled after the one that you
did for completion_matches():
   http://www.ca.postgresql.org/~petere/rl42-pg.patch

Shouldn't the declaration for filename_completion_function() be picked up
via readline.h?  IMO, redeclaring functions especially from an external
library (i.e., readline) is generally not considered good programming
practice.

Thanks,
Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: 732.264.8770 x235
Dot Hill Systems Corp.               Fax:   732.264.8798
82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com