Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

Tom,

On Fri, Apr 20, 2001 at 03:38:56PM -0400, Jason Tishler wrote:
> On Fri, Apr 20, 2001 at 02:38:53PM -0400, Tom Lane wrote:
> > That's a fair point.  Maybe it should be
> >
> > +#ifndef DLLIMPORT
> > +#ifdef __CYGWIN__
> > +#define DLLIMPORT __declspec (dllimport)
> > +#else
> > +#define DLLIMPORT
> > +#endif /* __CYGWIN__ */
> > +#endif /* DLLIMPORT */
>
> I will redo my patch with the modification suggested above.

I have redone my patch incorporating the above plus I fixed a glaring
hole now I know that sqlca.h is included by more then ESQL clients.
Without the src/makefiles/Makefile.win part, ecpg.dll no longer built
under Cygwin.

This time I have rebuilt everything from scratch on both Linux and
Cygwin without any errors.  I have also rerun the regression tests and
all passed.

I apologize for the sloppiness of my previous patch -- that will not
happen again.

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com