Re: Re: RELEASE STOPPER? nonportable int64 constants in pg_crc.c

Can we use (long long) rather than LL?


> > Zeugswetter Andreas SB  <ZeugswetterA@wien.spardat.at> writes:
> > > Recent changes in pg_crc.c (64 bit CRC) introduced non portable constants of the form:
> > 
> > >  -c -o pg_crc.o pg_crc.c
> > >       287 |         0x0000000000000000, 0x42F0E1EBA9EA3693,
> > >             ............................a..................
> > > a - 1506-207 (W) Integer constant 0x42F0E1EBA9EA3693 out of range.
> > 
> > Please observe that this is a warning, not an error.  Your proposed
> > fix is considerably worse than the disease, because it will break on
> > compilers that do not recognize "LL" constants, to say nothing of
> > machines where L is correct and LL is some yet wider datatype.
> 
> I am seeing the same warnings with gcc 2.7.2.1 -Wall on BSDi i386:
> 
> pg_crc.c:353: warning: integer constant out of range
> pg_crc.c:353: warning: integer constant out of range
> pg_crc.c:354: warning: integer constant out of range
> pg_crc.c:354: warning: integer constant out of range
> pg_crc.c:355: warning: integer constant out of range
> pg_crc.c:355: warning: integer constant out of range
> pg_crc.c:356: warning: integer constant out of range
> 
> -- 
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@candle.pha.pa.us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
> 
> http://www.postgresql.org/users-lounge/docs/faq.html
> 


--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026