Re: PHP 4.0.4pl1 / Beta 5

* Sascha Schumann <sascha@schumann.cx> [010219 10:57]:
> > AFAIK there is no need for you to be including <postgres.h> in *any*
> > Postgres release --- it's supposed to be an internal header file,
> > not something that client applications need.  Try it with just
> 
> /home/sas/src/php4/ext/pgsql/pgsql.c: In function `php_if_pg_getlastoid':
> /home/sas/src/php4/ext/pgsql/pgsql.c:1260: `InvalidOid' undeclared (first use in this function)
> /home/sas/src/php4/ext/pgsql/pgsql.c:1260: (Each undeclared identifier is reported only once
> /home/sas/src/php4/ext/pgsql/pgsql.c:1260: for each function it appears in.)
> 
>     InvalidOid is used to check the return value of PQoidValue().
> 
>     src/interfaces/libpq/fe-exec.c:PQoidValue() can return
>     InvalidOid, so this appears like a legitimate use to me.
>     Feel free to correct me though, I have not used the C fe
>     before.
I still think we need a dummy postgres.h in $(destdir)/include to
catch others using it this release.  PHP 4.0.4pl1 and earlier will
*BREAK* unless we do. 

This is a PROBLEM.

LER

> 
>     - Sascha

-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749