Re: [HACKERS] freefuncs.c is never called from anywhere!?
От | Bruce Momjian |
---|---|
Тема | Re: [HACKERS] freefuncs.c is never called from anywhere!? |
Дата | |
Msg-id | 200001300318.WAA18832@candle.pha.pa.us обсуждение исходный текст |
Ответ на | freefuncs.c is never called from anywhere!? (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: [HACKERS] freefuncs.c is never called from anywhere!?
Re: [HACKERS] freefuncs.c is never called from anywhere!? |
Список | pgsql-hackers |
> I was rather bemused to discover just now that the node-freeing > functions in nodes/freefuncs.c are never called from anywhere; > in fact, the module hasn't got a single exported entry point! > > (I expect that freeObject() is supposed to be an external entry > point; perhaps it got demoted to a static during one of Bruce's > periodic get-rid-of-unreferenced-global-symbols passes.) > > So much for all that tedious labor to maintain the freeXXX functions > every time we update a node type ;-) Are you sure about this? I thought these things were called from macros. However, I can't find any macro that uses this like makeNode does with its pasteing. I would perhaps move it to a _deadcode directory and see what happens. Or should we enable it? -- Bruce Momjian | http://www.op.net/~candle pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
В списке pgsql-hackers по дате отправления: