Re: Call perror on popen failure

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: Call perror on popen failure
Дата
Msg-id 1fcfa6c1-7d8c-4e17-b0ce-848164c9f31d@eisentraut.org
обсуждение исходный текст
Ответ на Call perror on popen failure  (Daniel Gustafsson <daniel@yesql.se>)
Ответы Re: Call perror on popen failure  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
On 08.03.24 11:05, Daniel Gustafsson wrote:
> If popen fails in pipe_read_line we invoke perror for the error message, and
> pipe_read_line is in turn called by find_other_exec which is used in both
> frontend and backend code.  This is an old codepath, and it seems like it ought
> to be replaced with the more common logging tools we now have like in the
> attached diff (which also makes the error translated as opposed to now).  Any
> objections to removing this last perror() call?

This change makes it consistent with other popen() calls, so it makes 
sense to me.




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Melanie Plageman
Дата:
Сообщение: Re: Confine vacuum skip logic to lazy_scan_skip
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Remove unnecessary code from psql's watch command