Re: [PATCH] few fts functions for jsonb

On 04/03/2017 02:22 PM, Andres Freund wrote:
> On 2017-04-01 16:20:46 -0400, Andrew Dunstan wrote:
>>
>> On 03/31/2017 03:17 PM, Oleg Bartunov wrote:
>>>
>>> On 30 Mar 2017 23:43, "Dmitry Dolgov" <9erthalion6@gmail.com
>>> <mailto:9erthalion6@gmail.com>> wrote:
>>>
>>>     On 31 March 2017 at 00:01, Andrew Dunstan
>>>     <andrew.dunstan@2ndquadrant.com
>>>     <mailto:andrew.dunstan@2ndquadrant.com>> wrote:
>>>     >
>>>     > I have just noticed as I was writing/testing the non-existent
>>>     docs for
>>>     > this patch that it doesn't supply variants of to_tsvector that
>>>     take a
>>>     > regconfig as the first argument. Is there a reason for that? Why
>>>     > should the json(b) versions be different from the text versions?
>>>
>>>     No, there is no reason, I just missed that. Here is a new version
>>>     of the patch (only the functions part)
>>>     to add those variants.
>>>
>>>
>>> Congratulations with patch committed, who will write an addition
>>> documentation? I think we need to touch  FTS and JSON parts.
>> I added documentation when I committed it for the new functions, in the
>> FTS section. I'm not sure what we need to add to the JSON section if
>> anything.
> I see that the CF entry for this hasn't been marked as committed:
> https://commitfest.postgresql.org/13/1054/
> Is there anything left here?
>


Says "Status committed" for me. I fixed this in Sunday after Tom prodded me.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services