Re: pgsql: Allow insert and update tuple routing and COPY for foreigntable

Fujita-san,

On 2019/04/25 22:17, Etsuro Fujita wrote:
> (2019/04/24 22:04), Laurenz Albe wrote:
>>    Before PostgreSQL v11, a foreign data wrapper could be certain that
>>    BeginForeignModify is always called before ExecForeignInsert.
>>    This is no longer true.
> 
> OK, how about something like the attached?  I reworded this a bit, though.

Thanks for the patch.

+     Note that this function is also called when inserting routed tuples into
+     a foreign-table partition or executing <command>COPY FROM</command> on
+     a foreign table, in which case it is called in a different way than it
+     is in the <command>INSERT</command> case.

Maybe minor, but should the last part of this sentence read as:

...in which case it is called in a different way than it is in the case
<command>INSERT</command> is operating directly on the foreign table.

?

Thanks,
Amit