Re: [HACKERS] MERGE SQL Statement for PG11

> The variable would become unused in non-assert builds. I see that. But simply 
> removing it is not a solution and I don't think the code will compile that way. 
> We should either rewrite that assertion or put it inside a #ifdef 
> ASSERT_CHECKING block or simple remove that assertion because we already check 
> for relkind in parse_merge.c. Will check.
> 

That is noted by Kyotaro HORIGUCHI
https://www.postgresql.org/message-id/20180405.181730.125855581.horiguchi.kyotaro%40lab.ntt.co.jp

and his suggestion to use special macro looks better for me:
-   char        relkind;
+   char        relkind PG_USED_FOR_ASSERTS_ONLY;


-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/