Re: [PATCH] updates to docs about HOT updates for BRIN

Поиск
Список
Период
Сортировка
От Jeff Davis
Тема Re: [PATCH] updates to docs about HOT updates for BRIN
Дата
Msg-id 1abb9150e7e50eace9e6cd7520e22c7404856f3b.camel@j-davis.com
обсуждение исходный текст
Ответ на Re: [PATCH] updates to docs about HOT updates for BRIN  (Stephen Frost <sfrost@snowman.net>)
Ответы Re: [PATCH] updates to docs about HOT updates for BRIN  (Elizabeth Christensen <elizabeth.christensen@crunchydata.com>)
Re: [PATCH] updates to docs about HOT updates for BRIN  (Stephen Frost <sfrost@snowman.net>)
Список pgsql-hackers
On Tue, 2024-02-27 at 09:48 -0500, Stephen Frost wrote:
> Attached is an updated patch which drops the 'such as' and adds a
> sentence mentioning that BRIN is the only in-core summarizing index.

The original patch reads more clearly to me. In v4, summarizing (the
exception) feels like it's dominating the description.

Also, is it standard practice to backport this kind of doc update? I
ordinarily wouldn't be inclined to do so, but v4 seems targeted at 16
as well.

Attached my own suggested wording that hopefully addresses Stephen and
Alvaro's concerns. I agree that it's tricky to write so I took a more
minimalist approach:

 * I got rid of the "In summary" sentence because (a) it's confusing
now that we're talking about summarizing indexes; and (b) it's not
summarizing anything, it's just redundant.

 * I removed the mention partial or expression indexes. It's a bit
redundant and doesn't seem especially helpful in this context.

If this is agreeable I can commit it.

Regards,
    Jeff Davis


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)
Следующее
От: Peter Smith
Дата:
Сообщение: Re: Synchronizing slots from primary to standby