Re: libpq support for NegotiateProtocolVersion

On 16.11.22 19:35, Jacob Champion wrote:
> On Tue, Nov 15, 2022 at 2:19 AM Peter Eisentraut
> <peter.eisentraut@enterprisedb.com> wrote:
>> I think for the current code, the following would be an appropriate
>> adjustment:
>>
>> diff --git a/src/interfaces/libpq/fe-connect.c
>> b/src/interfaces/libpq/fe-connect.c
>> index 746e9b4f1efc..d15fb96572d9 100644
>> --- a/src/interfaces/libpq/fe-connect.c
>> +++ b/src/interfaces/libpq/fe-connect.c
>> @@ -3412,8 +3412,7 @@ PQconnectPoll(PGconn *conn)
>>                   /* Get the type of request. */
>>                   if (pqGetInt((int *) &areq, 4, conn))
>>                   {
>> -                   /* We'll come back when there are more data */
>> -                   return PGRES_POLLING_READING;
>> +                   goto error_return;
>>                   }
>>                   msgLength -= 4;
>>
>> And then the handling of the 'v' message in my patch would also be
>> adjusted like that.
> 
> Yes -- though that particular example may be dead code, since we
> should have already checked that there are at least four more bytes in
> the buffer.

I have committed this change and the adjusted original patch.  Thanks.