Re: [PATCH] Add tests for Bitmapset

Поиск
Список
Период
Сортировка
От Greg Burd
Тема Re: [PATCH] Add tests for Bitmapset
Дата
Msg-id 1D776AE2-6027-4494-846F-B50B68B4356C@greg.burd.me
обсуждение исходный текст
Ответ на Re: [PATCH] Add tests for Bitmapset  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: [PATCH] Add tests for Bitmapset
Список pgsql-hackers
Hello hackers, :)

Thanks for all the feedback and time spent reviewing this patch.  I
switched out the encode/decode functions to use the nodeToString() and
stringToNode() functions and change all the SQL testing function
signatures to TEXT from BYTEA.  This exercises more code and that's good
for testing purposes.  I took out the code that checks the hash values,
I can't think of a reason that should cause a future failure should that
change and output different values.  I re-integrated the earlier random
testing function along with the newer code.  I'm not sure this buys us
much if anything.

coverage:      HEAD      v7
lines......:   87.1    90.5   +3.4%
functions..:  100.0   100.0   +0.0%
branches...:   63.5    75.9  +12.4%

best.

-greg

Вложения

В списке pgsql-hackers по дате отправления: