Re: [HACKERS] Questionable codes

> I have found a few questionable codings. I'm not sure if it really
> hurts anything. Suggestions are welcome.
> 
> 1) in storage/lmgr/lock.c: LockShmemSize()
> 
> size += MAXALIGN(maxBackends * sizeof(PROC));        /* each MyProc */
> size += MAXALIGN(maxBackends * sizeof(LOCKMETHODCTL));        /* each
> 
> shouldn't be:
> 
> size += maxBackends * MAXALIGN(sizeof(PROC));        /* each MyProc */
> size += maxBackends * MAXALIGN(sizeof(LOCKMETHODCTL));        /* each

Yes, you are correct.  The bottom one is better.

> 
> 2) in utils/hash/dynahash.c:hash_search():
> 
> Assert(saveState.currElem && !(saveState.currElem = 0));
> 
> Does anybody know what it is for?

No idea.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026