Re: [HACKERS] relcache.c leaks refcnts

> I believe that relcache.c should provide a routine (to be called during
> abort cleanup) that will reset the refcnts of all relcache entries to
> 0 for a normal rel and 1 for a nailed-in rel.  It might be a good idea
> to call this routine during normal xact commit, too, just in case
> someone forgets to decrement a refcnt they've incremented.
> 
> My earlier idea of having RelationFlushRelation rebuild the cache entry
> if it couldn't flush it would also mask this particular symptom.  But
> that wouldn't cure the gradual relcache growth that is likely to occur
> because of refcnt leakage.  I still think we probably want to do that
> too, though.

Yes, amazing it was this broken.  Clearing it makes sense.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026