Re: [HACKERS] 6.5.1
От | Bruce Momjian |
---|---|
Тема | Re: [HACKERS] 6.5.1 |
Дата | |
Msg-id | 199907110159.VAA07502@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: [HACKERS] 6.5.1 (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: [HACKERS] 6.5.1
|
Список | pgsql-hackers |
One thing I want to do for 6.6 is make sure each include file has the proper includes to compile just itself, and try to remove extra non-system includes in the C files. > I wrote: > > And, right offhand, I'm not seeing where <time.h> gets included before > > heapam.h is read. > > I dug into this and found that on my own machine, <sys/time.h> is pulled > in by <arpa/inet.h> which is pulled in by config.h (if the right > configuration symbols are defined). It looks to me like there is > noplace that explicitly pulls in <time.h> before heapam.h is read. > > In short, what we've got here is code that only works because of > interdependencies among system headers. Not too portable. > > I added "#include <time.h>" to heapam.h, which I think will fix Oleg's > problem, but I'm a little bit mystified why we didn't find this long > ago. Someone must have removed an #include somewhere that covered up > the problem... > > regards, tom lane > > -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
В списке pgsql-hackers по дате отправления: