Re: [HACKERS] I can't compile cvs snapshot ...
От | Bruce Momjian |
---|---|
Тема | Re: [HACKERS] I can't compile cvs snapshot ... |
Дата | |
Msg-id | 199905261506.LAA25278@candle.pha.pa.us обсуждение исходный текст |
Ответ на | Re: [HACKERS] I can't compile cvs snapshot ... (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-hackers |
> If pgindent mucks up standard C constructs then pgindent is broken. > > This is not open to debate --- if you are going to run our entire > source base through pgindent just a few days before every release, > then the tool has to be something we can have 100 percent, no-questions- > asked confidence in. Telling people to obey weird little coding > conventions is no answer. (If everyone reliably did that, we'd not > need pgindent in the first place.) > > It appears that BSD indent doesn't have a problem with 0xnnnL, so > teaching it about 0xnnnU can't be that hard if you have the source. > (I don't...) OK, here is the patch that is not in the tools/pgindent directory to understand 0x7fU constants. I will put the U's back in the constants. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 *** ./lexi.c.orig Wed May 26 10:50:54 1999 --- ./lexi.c Wed May 26 10:51:08 1999 *************** *** 186,192 **** *e_token++ = *buf_ptr++; } } ! if (*buf_ptr == 'L' || *buf_ptr == 'l') *e_token++ = *buf_ptr++; } else --- 186,193 ---- *e_token++ = *buf_ptr++; } } ! if (*buf_ptr == 'L' || *buf_ptr == 'U' || ! *buf_ptr == 'l' || *buf_ptr == 'u') *e_token++ = *buf_ptr++; } else
В списке pgsql-hackers по дате отправления: