Re: [HACKERS] Major breakage?

> I wrote:
> >> Is anyone else seeing major breakage of the regression tests with
> >> today's (Monday's) CVS checkins?  Or did I break something myself?
> 
> Nope, Vadim broke something.  It looks like anything with a subplan
> will coredump in Monday's sources.  executor/nodeSubPlan.c has
> 
> bool
> ExecInitSubPlan(SubPlan *node, EState *estate, Plan *parent)
> {
>     ...
>     ExecCheckPerms(CMD_SELECT, 0, node->rtable, (Query *) NULL);
>                                                 ^^^^^^^^^^^^^^
> 
> (and has had that for a long time, evidently).  One of the additions
> Vadim checked in yesterday extends ExecCheckPerms() to try to use
> its parseTree argument --- unconditionally.  Guaranteed null-pointer
> dereference.
> 
> Perhaps ExecInitSubPlan is in error to pass a null parseTree; if not,
> then ExecCheckPerms needs to be modified to cope.  I don't understand
> either routine enough to fix it correctly.

I caused the 'having' problems.  I am working on a fix.
--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026