Re: [HACKERS] CURRENT: crash in select_view regression test...

Appologies,

It looks like this was not the fix, as I'm still getting the
Bad node message....


Will continue investigating.

Keith.

Keith Parks <emkxp01@mtcc.demon.co.uk>
> 
> Vadim Mikheev <vadim@krs.ru>
> > 
> > Keith Parks wrote:
> > > 
> > > Vadim Mikheev <vadim@krs.ru>
> > > >
> > > > ... in SELECT * FROM street;
> > > >
> > > 
> > > No crash just:-
> > > 
> > > regression=> select * from street;
> > > ERROR:  nodeRead: Bad type 0
> > > regression=>
> > 
> > It seems platform dependent...
> > Bugs are in readfuncs.c
> > 
> 
> I think I've found it, a simple typo in outfuncs.c.
> 
> Looks like :vartypmod got transmuted to %vartypmod in an editing session.
> 
> Here's the patch,
> 
> Keith.
> 
> *** src/backend/nodes/outfuncs.c.orig   Thu Dec 17 12:01:02 1998
> --- src/backend/nodes/outfuncs.c        Thu Dec 17 12:01:22 1998
> ***************
> *** 634,640 ****
>   _outVar(StringInfo str, Var *node)
>   {
>         appendStringInfo(str,
> !                       " VAR :varno %d :varattno %d :vartype %u %vartypmod %d ",
>                         node->varno,
>                         node->varattno,
>                         node->vartype,
> --- 634,640 ----
>   _outVar(StringInfo str, Var *node)
>   {
>         appendStringInfo(str,
> !                       " VAR :varno %d :varattno %d :vartype %u :vartypmod %d ",
>                         node->varno,
>                         node->varattno,
>                         node->vartype,    
> 
>