Re: [PATCHES] [REL6_4] pg_dumpall & binary cursor fix in MB support

I have posted following patches on Nov 12 and do not see them in the
REL6_4 tree. Please let me know the patches are acceptable or not.
If ok, please apply them to 6.5 tree also.

> Included patches should fix following problems in the muti-byte
> enabled PostgreSQL 6.4.
> 
> o binary cursor does not work
> o pg_dumpall produces incorrect create database statemnt
> 
> Tatsuo Ishii
> t-ishii@sra.co.jp
> -------------------------------------------------------------------------
> *** postgresql-v6.4/src/backend/access/common/printtup.c~    Sat Nov  7 11:47:47 1998
> --- postgresql-v6.4/src/backend/access/common/printtup.c    Sat Nov  7 11:48:37 1998
> ***************
> *** 289,300 ****
>                   /* variable length, assume a varlena structure */
>                   len = VARSIZE(attr) - VARHDRSZ;
>   
> - #ifdef MULTIBYTE
> -                 pq_putncharlen(VARDATA(attr), len);
> - #else
>                   pq_putint(len, VARHDRSZ);
>                   pq_putnchar(VARDATA(attr), len);
> ! #endif
>   #ifdef IPORTAL_DEBUG
>                   {
>                       char       *d = VARDATA(attr);
> --- 289,297 ----
>                   /* variable length, assume a varlena structure */
>                   len = VARSIZE(attr) - VARHDRSZ;
>   
>                   pq_putint(len, VARHDRSZ);
>                   pq_putnchar(VARDATA(attr), len);
> ! 
>   #ifdef IPORTAL_DEBUG
>                   {
>                       char       *d = VARDATA(attr);
> *** postgresql-v6.4/src/bin/pg_dump/pg_dumpall~    Mon Aug 24 10:14:06 1998
> --- postgresql-v6.4/src/bin/pg_dump/pg_dumpall    Sat Nov  7 11:51:12 1998
> ***************
> *** 59,65 ****
>   
>       if createdb -help|grep encoding >/dev/null
>       then
> !         echo "create database with encoding='`pg_encoding $ENCODING`' $DATABASE;"
>       else
>           echo "create database $DATABASE;"
>       fi
> --- 59,65 ----
>   
>       if createdb -help|grep encoding >/dev/null
>       then
> !         echo "create database $DATABASE with encoding='`pg_encoding $ENCODING`';"
>       else
>           echo "create database $DATABASE;"
>       fi
>