Re: [HACKERS] questionable code in heap_formtuple()]

> > > around line 812 in access/common/heaptuple.c:
> > >
> > >     len = sizeof *tuple - sizeof tuple->t_bits;
> > >
> > > This seems questionable for me.
>
>
> > > I think more acculate way to calculate the offset is:
> > >
> > >     len = (char *)&tuple->t_bits[0] - (char *)tuple;
>
> OK, now I am more confused.  Doesn't this work:
>
>     len = sizeof(HeapTupleData) - offsetof(HeapTupleData.t_bits);
>
> while your solution is finding the size of the area before t_bits?

OK, I finally get it.  I was thinking HeapTupleData had the tuple data
in the structure, while obviously it does not.

Sometimes there is no HeapTuple to get the size of at the point you need
it, so I have applied a patch to do

    len = offsetof(HeapTupleData.t_bits);

which should fix the obvious problem Tatsuo Ishii found.  Does that fix
anything, index people?

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)