Re: [HACKERS] odd pg_dump output?

> >Thanks Tatsuo! But these are older problems, not new breakage from me,
> >right? Have you had a chance to test the latest pg_dump with your
> >patches? I'm still concerned that I didn't test pg_dump with a
> >regression test dump/reload/dump sequence (by comparing the two dump
> >files).
>
> I ran pg_dump with the regression DB, then did psql to reload.
> seems there are some problems in the output from pg_dump.
>
> BTW, this is FreeBSD 2.2.6 and one of the regression gets dump core
> (select_having).
> --
> Tatsuo Ishii
> t-ishii@sra.co.jp
>
> CREATE TYPE widget ( internallength = 24, externallength = -1, input = 144673(widget_in), output =
144674(widget_out),send = 144674(widget_out), receive = 144673(widget_in), default = '-'); 
> ERROR:  parser: parse error at or near "("
> CREATE TYPE _widget ( internallength = -1, externallength = -1, input = 750(array_in), output = 751(array_out), send
=751(array_out), receive = 750(array_in), default = '-'); 
> ERROR:  parser: parse error at or near "("

OK, this is my mistake.  The regproc fields output the pg_proc.proname,
but that is not unique, and should not be used to load into those
fields.  I prepended the object id of the pg_proc entry, to try and make
it more reliable, but forgot the parentheses would mess up the scannar.

I have changed 233(proname) to proname_233, which will now work.

Sorry.


--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)