Re: [HACKERS] Core dump in regression tests.

> > Thomas A. Szybist" <szybist@boxhill.com>
> > > Bruce Momjian <maillist@candle.pha.pa.us>
> > >
> > > Again, if someone wants to conditionally compile the directories to find
> > > the offending file, I am sure we can get a fix for it.
> > >
> >
> > At first look it seems to be:  backend/catalog/indexing.c.
> > Maybe Keith can confirm?
> >
> > Thanks,
>
> Tom,
>
> I recompiled the latest cvs with -O2 and found that the crash on
> table creation was NOT now failing so I'm a little confused :-(
>
> I'm just updating my cvs, and will do another build and see how
> things go.
>
> If only I had the same failures as before I'd be able to confirm
> your suspicions on indexing.c

I have found a problem in indexing.c.  In CatalogIndexFetchTuple(),
there is a particulary weird do..while loop, and in trying to clean it
up as part of the megapatch, I broke it and thought I had it fixed.

It appears it may still be broken.  The ReleaseBuffer(buffer) call could
happen even if no valid tuple is returned because buffer has a random
value.

I am running a test now, and will post the fix as soon as I am sure it
works.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)