Re: new MB patch and pg_type oid problem

> >> o these patches are made against the latest source tree (after Bruce's
> >> massive patch, I think) BTW, I noticed that after running regression,
> >> the oid field of pg_type seems disappeared.
> >>
> >>     regression=> select oid from pg_type;
> >>     ERROR:  attribute 'oid' not found
> >
> >I just tried:
> >
> >    select oid from pg_type;
> >
> >and it worked.
> >
> >>
> >> this happens after the constraints test. This occures with/without my
> >> patches. strange...
> >
> >What contraints test?
>
> The constraints test in the regression test suite.  Following step
> should reproduce the problem.
>
> ------------------------------------------------
> % cd src/test/regress
> % gmake all
> % createdb test
> % psql -c "select count(oid) from pg_type" test
> count
> -----
>   106
> (1 row)
> % psql test < sql/constraints.sql
> % psql -c "select count(oid) from pg_type" test
> ERROR:  attribute 'oid' not found
> ------------------------------------------------
>
> I found the problem while debugging pg_dump command. I ran the
> regression test, then tried to dump the regression database using
> pg_dump that failed with an error message:
>
>     getTypes(): SELECT failed
>
> Inspecting the regression test step by step, I found the "no oid
> attribute problem" had occured right after the constraints test.

OK, I have fixed this problem in the code.  I had messed up index
destruction badly.

The constraint regression test works now for me, while it did not
before.  Should be good.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)