Re: [HACKERS] Bug in linking in old libraries

>
> Bruce Momjian <maillist@candle.pha.pa.us> writes:
> > I have found a problem with libpgtcl and cases where the linking brings
> > in the old libpq libraries in the current installed directory, rather
> > than the one in the current source.
>
> This strikes me as just plain brain fade in src/bin/pgtclsh/Makefile.
> Instead of
>
> # try to find libpgtcl.a in either directory
> LIBPGTCL= -L$(SRCDIR)/interfaces/libpgtcl -L$(LIBDIR) -lpgtcl
> LIBPQ= -L$(LIBPQDIR) -L$(LIBDIR) -lpq
>
> it should just have
>
> LIBPGTCL= -L$(SRCDIR)/interfaces/libpgtcl -lpgtcl
> LIBPQ= -L$(LIBPQDIR) -lpq
>
> There's no good reason to be referencing the library install directory,
> since even if it exists it may contain an incompatible down-rev library.
>
> On some machines there is an issue of telling the executable to look for
> shared libraries in LIBDIR at run time, but that is handled by different
> switches that Makefile.port supplies via LDFLAGS.
>
> A quick grep for LIBDIR shows no indication that the same mistake has
> been made anywhere else.

Thanks for checking.  I will make the change.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)