Re: [HACKERS] CREATE FUNCTION broken

I added typmod to the TypeName structure, but am not aware of adding any
TypeName structure instance to anything.

Nice you have a patch for us.

>
> Hi,
>
>     Someone changed the parser to build a TypeName node on CREATE
>     FUNCTION in any  case.  As  a  side  effect,  ALL!  functions
>     created  got  the  proretset  attribute  to  true. Thus for a
>     SELECT the parser wrapped an Iter node around  the  Expr  and
>     since  singleton  functions  set  isDone  the Iter returns no
>     tuple up.
>
>
> Until later, Jan
>
> --
>
> #======================================================================#
> # It's easier to get forgiveness for being wrong than for being right. #
> # Let's break this rule - forgive me.                                  #
> #======================================== jwieck@debis.com (Jan Wieck) #
>
>
> *** define.c.orig    Fri Feb 13 12:14:17 1998
> --- define.c    Fri Feb 13 12:14:38 1998
> ***************
> *** 94,100 ****
>           TypeName   *setType = (TypeName *) returnType;
>
>           *prorettype_p = setType->name;
> !         *returnsSet_p = true;
>       }
>       else
>       {
> --- 94,100 ----
>           TypeName   *setType = (TypeName *) returnType;
>
>           *prorettype_p = setType->name;
> !         *returnsSet_p = setType->setof;
>       }
>       else
>       {
>
>


--
Bruce Momjian
maillist@candle.pha.pa.us