Re: SSI error messages

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> I think I would prefer something like this:

> ERROR:  could not serialize access due to read/write dependencies among 
> transactions
> DETAIL: Reason code: %s
> HINT:  The transaction might succeed if retried.

> That's my 2c, anyway. I see you committed this already, I don't 
> violently object to that either...

Well, as I mentioned in the commit message, I've thought for some time
that there were use cases for errdetail_internal.  Whether these
particular places in predicate.c use it or not doesn't affect that.

I don't have a strong opinion about whether to do it like you suggest,
other than that the proposed wording doesn't meet the message style
guideline about detail messages being complete sentences.
        regards, tom lane