Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Chris said he did:
>> Well all I did to fix it on FreeBSD was to remove the '-o "$LOGNAME" =
>> 'root'' bit...
> so I figured the patch would help, no?
No, because there's no good reason to suppose that $USER wouldn't be set.
I think we should remove that entire code block, and instead check for a
zero value of EffectiveUser after doing the id bit.
(I'm not finding it right now, but I'm pretty sure that the SUS
specifies that numeric userid == 0 for superuser, whereas "root" is not
required to be the name, so this would be more correct anyway.)
regards, tom lane