Re: pgsql: Check that we have a working tar before trying to use it

On 12/13/21 03:08, Michael Paquier wrote:
> Also,
> the default values of LZ4, TAR and GZIP_PROGRAM had better be set
> *before* loading buildenv.pl, and not after it is loaded, no?  On
> HEAD, one has no way to unset any of those variables so it is not
> possible to skip things if an environment has in its PATH a funky
> command that TAP would refuse, like a tar command from MinGW or the
> git installation.


No. The code only sets them if they have not been previously set by
buildenv.pl or the calling environment. That's what "||=" means.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com