Re: Re: [CORE] Re: MY PATCH

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> #5  0x81487bf in ExceptionalCondition (
>     conditionName=0x8195bd6 "!((relation)->rd_refcnt > 0)",
>     exceptionP=0x819f8fc, detail=0x0, fileName=0x8195a21 "relcache.c",
>     lineNumber=1337) at assert.c:73
> #6  0x81457e2 in RelationClose (relation=0x8243268) at relcache.c:1337
> #7  0x8072803 in heap_close (relation=0x8243268, lockmode=0) at heapam.c:620
> #8  0x80ae9e2 in EndPlan (plan=0x824bf90, estate=0x824cc18) at execMain.c:958
> #9  0x80ae2b0 in ExecutorEnd (queryDesc=0x824cc00, estate=0x824cc18)
>     at execMain.c:358
> #10 0x810db6c in ProcessQueryDesc (queryDesc=0x824cc00, limoffset=0x0,
>     limcount=0x0) at pquery.c:336
> #11 0x810dbce in ProcessQuery (parsetree=0x8234288, plan=0x824bf90,
>     dest=Remote) at pquery.c:369
> #12 0x810c5df in pg_exec_query_dest (
>     query_string=0x81cd368 "UPDATE a SET aa='zzzz' WHERE aa='aaaa';",
>     dest=Remote, aclOverride=0) at postgres.c:642

I'll betcha this is the same situation that I guessed at in my crash
report: the executor is probably trying to shut down the same plan node
twice.

BTW, the reason I didn't see this particular crash is that I don't
*have* an 'inherit' regression test:

$ ls pgsql/src/test/regress/*inherit*
pgsql/src/test/regress/*inherit* not found

Did you forget to commit some files, Bruce?

Note to Chris: --enable-cassert is an absolute requirement for
testing backend changes, and personally I like to build with
-DCLOBBER_FREED_MEMORY as well.

            regards, tom lane