Re: Two small patches for the isolationtester lexer
От | Tom Lane |
---|---|
Тема | Re: Two small patches for the isolationtester lexer |
Дата | |
Msg-id | 1859.1519247402@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Two small patches for the isolationtester lexer (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: Two small patches for the isolationtester lexer
|
Список | pgsql-hackers |
I wrote; > Daniel Gustafsson <daniel@yesql.se> writes: >> I also (again) forgot about the # comments not being allowed inside setup and >> teardown blocks, so patch 0002 proposes adding support for these as the >> documentation implies. > Hmm, not sure this is a good idea. # is a valid SQL operator name, so > doing this would create some risk of breaking legal queries. Actually, looking closer, this would also trigger on '#' used inside a SQL literal, which seems to move the problem cases into the "pretty likely" category instead of the "far-fetched" one. So I'd only be OK with it if we made the lexer smart enough to distinguish inside-a-SQL- literal from not. That might be a good thing anyway, since it would allow us to not choke on literals containing '}', but it'd be a great deal more work. You might be able to steal code from the psql lexer though. regards, tom lane
В списке pgsql-hackers по дате отправления: