Re: make check failure for 8.4.0

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Kevin Grittner wrote:
>> Bingo!  A few weeks back I had been experimenting with using the PGXS
>> compiles for our extensions, rather than expanding our tarballs in the
>> build tree and just doing make and sudo make install there.  On the
>> failing machine, the session I used has USE_PGXS defined.  I unset
>> that and out of paranoia I did a make distclean and started over. 

> This seems like a bug in the PGXS stuff that oughta be fixed.

Well, PGXS per se is just doing what it was told to.  What I was
thinking is that we should arrange to un-define USE_PGXS during a
standard in-tree build of contrib/.  It's not quite clear to me
where that should happen though.  Is contrib/Makefile the right place?
That would mean that issuing "make" within a contrib module directory
might behave differently from saying "make" at a higher level.  Maybe
that's what we want --- I can certainly imagine wishing to activate
PGXS while building a contrib module, even if it happens to be inside
a Postgres source tree.
        regards, tom lane