Re: Synchronizing slots from primary to standby

Hi,

On 10/18/23 6:43 AM, shveta malik wrote:
> On Tue, Oct 17, 2023 at 9:06 PM Drouvot, Bertrand
>> +static void
>> +ProcessRepliesAndTimeOut(void)
>> +{
>> +       CHECK_FOR_INTERRUPTS();
>> +
>> +       /* Process any requests or signals received recently */
>> +       if (ConfigReloadPending)
>> +       {
>> +               ConfigReloadPending = false;
>> +               ProcessConfigFile(PGC_SIGHUP);
>> +               SyncRepInitConfig();
>> +               SlotSyncInitConfig();
>> +       }
>>
>> Do we want to do this at each place ProcessRepliesAndTimeOut() is being
>> called? I mean before this change it was not done in ProcessPendingWrites().
>>
> 
> Are you referring to ConfigReload stuff ? I see that even in
> ProcessPendingWrites(), we do it after WalSndWait(). Now only the
> order is changed, it is before  WalSndWait() now.

Yeah and the CFI.

With the patch the CFI and check on ConfigReloadPending is done in all the case
as the break (if !pq_is_send_pending()) is now done after. That seems ok, just
wanted to mention it.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com