Re: pgAdmin III commit: Support the new check_option parameter of views

Hello Guillaume,

I've noticed that views for which I had never specified check_option
or security_barrier (in pgsql 9.3) have got incorrect DDL generated -
the "WITH (options)" clause is empty:

CREATE OR REPLACE VIEW account_v WITH () AS
 SELECT acc.id,
...

Once I set security_barrier on and back off for a view, it starts
showing "WITH (security_barrier=FALSE)", not an empty "WITH ()" until
I recreate a view. Probably that is the reason why the issue went
unnoticed during development.

Attached patch should fix it.


Wednesday, July 2, 2014, 7:47:42 PM, you wrote:

GL> Support the new check_option parameter of views

GL> Branch
GL> ------
GL> master

GL> Details
GL> -------
GL> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=178f27be48c6c1af970a104d590e4d3abaccdcc4

GL> Modified Files
GL> --------------
GL> CHANGELOG                       |    1 +
GL> pgadmin/dlg/dlgView.cpp         |   50
GL> +++++++++++++++++++++++++++++++++++----
GL> pgadmin/include/schema/pgView.h |   11 ++++++++-
GL> pgadmin/schema/pgView.cpp       |   23 +++++++++++++++++-
GL> pgadmin/ui/dlgView.xrc          |   23 ++++++++++++++++--
GL> 5 files changed, 99 insertions(+), 9 deletions(-)





--
Best regards,
 J.F.