Re: Cannot build docs on Ubuntu 10.04?
От | Tom Lane |
---|---|
Тема | Re: Cannot build docs on Ubuntu 10.04? |
Дата | |
Msg-id | 17355.1332389571@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Cannot build docs on Ubuntu 10.04? (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-docs |
I wrote: > Maybe the Makefile should just error out if COLLATEINDEX isn't set, > rather than trying a "fallback" value that configure has already > determined isn't going to work. I looked at this a bit closer, and figured out why the Makefile is trying an apparently pointless case: the test implemented in configure is wrong! In at least some installations of docbook, for instance the ancient one I've got in captivity on my HPUX box, collateindex.pl is provided in $(DOCBOOKSTYLE)/bin/, but *it is not marked executable*. This causes AC_PATH_PROGS to not consider it valid. However, the docs Makefile is coded to invoke the script via $(PERL) $(COLLATEINDEX), which is presumably done precisely to be able to cope with not-executable scripts. So I think we should adjust the configure test to accept $(DOCBOOKSTYLE)/bin/collateindex.pl if it is readable, whether or not it is executable, and only use the Autoconf macro if we fall back to searching PATH for collateindex.pl. Having done that, it should be safe to simplify the Makefile to throw error if COLLATEINDEX isn't set. regards, tom lane
В списке pgsql-docs по дате отправления: