Re: pg_waldump: add test for coverage
От | Tristen Raab |
---|---|
Тема | Re: pg_waldump: add test for coverage |
Дата | |
Msg-id | 168806621290.1114.6526720863694392620.pgcf@coridan.postgresql.org обсуждение исходный текст |
Ответ на | Re: pg_waldump: add test for coverage (Peter Eisentraut <peter@eisentraut.org>) |
Ответы |
Re: pg_waldump: add test for coverage
|
Список | pgsql-hackers |
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation: not tested Hello, I've reviewed your latest v3 patches on Ubuntu 23.04. Both patches apply correctly and all the tests run and pass as theyshould. Execution time was normal for me, I didn't notice any significant latency when compared to other tests. The onlyother feedback I can provide would be to add test coverage to some of the other options that aren't currently covered(ie. --bkp-details, --end, --follow, --path, etc.) for completeness. Other than that, this looks like a great patch. Kind regards, Tristen
В списке pgsql-hackers по дате отправления: