Re: [HACKERS] RE: cvs-commit-digest V1 #856

"Hiroshi Inoue" <Inoue@tpf.co.jp> writes:
>> From: Peter Eisentraut - PostgreSQL <petere>
>> Commented out way old printing functions in libpq

> pqbool is removed from libpq-fe.h.
> Couldn't compile interfaces/perl5 now.

> In addition,this seems to change external interface of PQprint().
> Is it OK ?

Not IMHO.  It looks like Peter has removed typedef pqbool (potentially
breaking application sources, not just perl5) and changed what were
pqbool == char fields into int fields (thereby breaking binaries that
depend on shared libraries of libpq).  Not to mention the advertised
change of removing documented API entry points.

Peter, you need to have a little more respect for stability of
library APIs.  Gratuitous breaking of backwards compatibility
is not the done thing around here.  It's especially not done
without any discussion.
        regards, tom lane