Re: [PATCH] Allow Postgres to pick an unused port to listen
От | Tristen Raab |
---|---|
Тема | Re: [PATCH] Allow Postgres to pick an unused port to listen |
Дата | |
Msg-id | 168434866923.1144.17948629630066944490.pgcf@coridan.postgresql.org обсуждение исходный текст |
Ответ на | Re: [PATCH] Allow Postgres to pick an unused port to listen (Yurii Rashkovskii <yrashk@gmail.com>) |
Ответы |
Re: [PATCH] Allow Postgres to pick an unused port to listen
|
Список | pgsql-hackers |
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation: tested, passed Hello Yurii, I've retested your latest patch and tested building the documentation. I agree with the general sentiment that this is an interesting, albeit specific feature. Nevertheless, I would still liketo see this integrated. My only concern, like many others have voiced, is in regard to the port number. When I was reviewingthis patch I found it quite unintuitive to rummage through the postmaster.pid to find the correct port. I thinkeither a specific pg_ctl command to return the port like Greg had initially mentioned or simply a separate file to storethe port numbers would be ideal. The standalone file being the simpler option, this would free up postmaster.pid toallow any future alterations and still be able to reliably get the port number when using this wildcard. We can also buildon this file later to allow for multiple ports to be listened on as previously suggested. Kind regards, Tristen
В списке pgsql-hackers по дате отправления: