Re: Signals inheritance work - major problems
От | Tom Lane |
---|---|
Тема | Re: Signals inheritance work - major problems |
Дата | |
Msg-id | 16565.1099513774@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Signals inheritance work - major problems ("Magnus Hagander" <mha@sollentuna.net>) |
Ответы |
Re: Signals inheritance work - major problems
|
Список | pgsql-hackers-win32 |
"Magnus Hagander" <mha@sollentuna.net> writes: > But if I move the signals initialization code to after the backend file > read, that is a *lot* later. This is also *after* the backend has set up > it's signal handlers, which will crash if things aren't initialized. Hm? read_backend_variables() happens in SubPostmasterMain(), which certainly hasn't yet set up any signal handlers. (It has done a PG_SETMASK, but that could be moved down a few lines if it's a problem; but my guess is that you want to do that before starting the signals thread anyway.) I'd be inclined to think in terms of just moving the pgwin32_signal_initialize() call out of main.c and into SubPostmasterMain; you'd also need it in PostmasterMain and BootstrapMain I suppose, but that's not as bad as any of the alternatives you mention. regards, tom lane
В списке pgsql-hackers-win32 по дате отправления: