Re: New acinclude.m4

Yes.  Nice catch.

On May 19, 2005, at 1:07 PM, Raphaël Enrici wrote:


> Dave Page wrote:
>
>
>>
>>
>>
>>
>>
>>> -----Original Message-----
>>> From: pgadmin-hackers-owner@postgresql.org
>>> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
>>> Adam H. Pendleton
>>> Sent: 18 May 2005 22:26
>>> To: pgadmin-hackers@postgresql.org
>>> Subject: [pgadmin-hackers] New acinclude.m4
>>>
>>> Attached is a new acinclude.m4, and a patch to our current
>>> acinclude,
>>> that relies on wx-config for all the flags.  Gone is all the
>>> complicated stuff.  The only thing this new acinclude doesn't do is
>>> warn about a missing stc or ogl.  It will link against them,
>>> but if a
>>> user doesn't have them, their compile will fail.  I'll be adding in
>>> stub programs to test for this in my next version.  In the meantime,
>>> test and enjoy.
>>>
>>>
>>
>>
>> Great, thanks Adam - committed.
>>
>>
>
>
> I have warning concerning ENABLE_STATIC in configure script. Shouldn't
> we also remove it crom configure.ac ? (patch attached).
>
> Regards,
> Raphaël
> Index: configure.ac
> ===================================================================
> --- configure.ac    (revision 4219)
> +++ configure.ac    (working copy)
> @@ -35,7 +35,6 @@
>  CHECK_WX_CONFIG_BINARY
>  CHECK_PGSQL_INCLUDE
>  ENABLE_DEBUG
> -ENABLE_STATIC
>  CHECK_PGSQL
>  CHECK_WXWINDOWS
>
>
>