Re: Fix typo about WalSndPrepareWrite
От | Cary Huang |
---|---|
Тема | Re: Fix typo about WalSndPrepareWrite |
Дата | |
Msg-id | 161358563718.24325.3410339738199469749.pgcf@coridan.postgresql.org обсуждение исходный текст |
Ответ на | Re: Fix typo about WalSndPrepareWrite (japin <japinli@hotmail.com>) |
Ответы |
Re: Fix typo about WalSndPrepareWrite
|
Список | pgsql-hackers |
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation: tested, passed Hi, thanks for the patch, however I don't think it is a typo. The comment indicates a technique that is used throughout manyfunctions in walsender.c, which is to fill the send-timestamp as late as possible so it is more accurate. This is doneby first reserving a spot in the write stream, write the actual data, and then finally write the current timestamp tothe reserved spot. This technique is used in WalSndWriteData() and also XLogSendPhysical()... so really it doesn't matterwhich function name to put in the comment. thank you! ----------- Cary Huang HighGo Software (Canada)
В списке pgsql-hackers по дате отправления: