Re: [HACKERS] Sigh, build is broken again
От | Tom Lane |
---|---|
Тема | Re: [HACKERS] Sigh, build is broken again |
Дата | |
Msg-id | 16059.913395758@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: [HACKERS] Sigh, build is broken again (Bruce Momjian <maillist@candle.pha.pa.us>) |
Список | pgsql-hackers |
Bruce Momjian <maillist@candle.pha.pa.us> writes: > Is this item resolved? >> Someone checked in code that assumes vsnprintf() exists. >> >> Should be cool, we have an emulation right? Well, no. >> configure sets up to build port/snprintf.c if snprintf() >> doesn't exist. HPUX, for one, has that but not vsnprintf. >> >> I guess the right fix is for configure to check for *both* >> snprintf and vsnprintf --- anyone see a problem with that? No, we backed out the original patch and thus made the problem go away for 6.4. That's where it still stands, AFAIK. I'd suggest re-committing the original patch (something to do with tracing, IIRC) but to the 6.5 branch *only*. The argument about not having done enough testing applies even more strongly to 6.4.1 than it did for 6.4. But if we put it into 6.5 now, we should have some track record with vsnprintf before 6.5 hits the streets. As soon as you commit the trace patch, my build will break, and then I'll do something about fixing configure to check for vsnprintf ;-) regards, tom lane
В списке pgsql-hackers по дате отправления: