Re[4]: bool_plperl transform
От | Ivan Panchenko |
---|---|
Тема | Re[4]: bool_plperl transform |
Дата | |
Msg-id | 1583107300.299213059@f529.i.mail.ru обсуждение исходный текст |
Ответ на | Re: Re[2]: bool_plperl transform (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: Re[4]: bool_plperl transform
|
Список | pgsql-hackers |
Thanks, Tom.
I think now it should build, please find the fixed patch attached.
I had no possibility to check it on Windows now, but the relevant changes in Mkvcbuild.pm are done, so I hope it should work.
The documentation changes are also included in the same patch.
Regards,
Ivan
Понедельник, 2 марта 2020, 0:14 +03:00 от Tom Lane <tgl@sss.pgh.pa.us>:
Wao <wao@mail.ru> writes:> Please find the full patch attached.
The cfbot shows this failing to build on Windows:
https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.81889
I believe that's a build without plperl, so what it's probably telling
you is that Mkvcbuild.pm needs to be taught to build this module
conditionally, as it already does for hstore_plperl and jsonb_plperl.
Also, while the Linux build is passing, I can't find that it is actually
compiling or testing bool_plperl anywhere:
https://travis-ci.org/postgresql-cfbot/postgresql/builds/656909114
This is likely because you didn't add it to contrib/Makefile.
In general, I'd suggest grepping for references to hstore_plperl
or jsonb_plperl, and making sure that bool_plperl gets added where
appropriate.
I rather imagine you need a .gitignore file, as well.
You're also going to have to provide some documentation, because
I don't see any in the patch.
regards, tom lane
Вложения
В списке pgsql-hackers по дате отправления: