Re: Make pg_stat_io view count IOs as bytes instead of blocks

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Make pg_stat_io view count IOs as bytes instead of blocks
Дата
Msg-id 1550522.1737006437@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Make pg_stat_io view count IOs as bytes instead of blocks  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Ответы Re: Make pg_stat_io view count IOs as bytes instead of blocks
Список pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> Not completely sure about the number of parenthesis, but I hope that
> this should be enough (extra set around io_op):
> +#define pgstat_is_ioop_tracked_in_bytes(io_op) \
> +    (((unsigned int) (io_op)) < IOOP_NUM_TYPES && \
> +     ((unsigned int) (io_op)) >= IOOP_EXTEND)

Yeah, that's safe parenthesis-wise.  Whether it'll silence
the warning from those old clangs remains to be seen.

(But if it doesn't, maybe it's not worth working harder,
given that they're old.)

            regards, tom lane



В списке pgsql-hackers по дате отправления: