Re: Fix overflow in DecodeInterval
От | Tom Lane |
---|---|
Тема | Re: Fix overflow in DecodeInterval |
Дата | |
Msg-id | 1531188.1648930455@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Fix overflow in DecodeInterval (Joseph Koshakow <koshy44@gmail.com>) |
Ответы |
Re: Fix overflow in DecodeInterval
|
Список | pgsql-hackers |
Joseph Koshakow <koshy44@gmail.com> writes: > On Sat, Apr 2, 2022 at 3:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I think it's not, at least not for the interesting range of possible >> values in this code. Given that abs(frac) < 1 to start with, the >> abs value of usec can't exceed the value of scale, which is at most >> USECS_PER_DAY so it's at most 37 or so bits, which is well within >> the exact range for any sane implementation of double. It would >> take a very poor floating-point implementation to not get the right >> answer here. (And we're largely assuming IEEE-compliant floats these >> days.) > Ah, I see. That makes sense to me. Cool. I've pushed the patch. regards, tom lane
В списке pgsql-hackers по дате отправления: