Re: libpq Win32 Mutex performance patch

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: libpq Win32 Mutex performance patch
Дата
Msg-id 15033.1207940408@sss.pgh.pa.us
обсуждение исходный текст
Ответ на libpq Win32 Mutex performance patch  (Andrew Chernow <ac@esilo.com>)
Ответы Re: libpq Win32 Mutex performance patch  (Andrew Chernow <ac@esilo.com>)
Re: libpq Win32 Mutex performance patch  (Andrew Chernow <ac@esilo.com>)
Список pgsql-patches
Andrew Chernow <ac@esilo.com> writes:
> The attached patch replaces the win32 mutex calls with critical section
> calls.  The change will not affect the behavior of the windows
> pthread_xxx functions.

Why have you defined the lock/unlock functions as willing to fall
through silently if handed a null pointer?  I think a crash in
such a case is what we *want*.  Silently not locking is surely
not very safe.

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: "Merlin Moncure"
Дата:
Сообщение: Re: libpq Win32 Mutex performance patch
Следующее
От: Andrew Chernow
Дата:
Сообщение: Re: libpq Win32 Mutex performance patch