Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> Hmm. One suggestion would be to have an internal function declared
>> as taking and returning "struct varlena *", with a comment saying that
>> we depend on text and bytea both being compatible with this. All three
>> SQL-visible functions are then thin wrappers around that.
> Doesn't strike me as much of an advance, to be honest.
As you wish, but at least a comment noting that these functions are
relying on binary compatibility of text and bytea would be a good idea.
> My current top priority is fixing the MSVC build .bat files like Magnus
> wants, which will take a bit of time.
If you are intending to make the buildfarm use the perl scripts, then
this should definitely be high priority --- we don't want the farm
testing some other build process than what ordinary users will use.
regards, tom lane