Re: Some 8.4 changes needed according to pg_migrator testing

Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> One problem that just occurred to me is that this solution may not be
>> adequate for pg_migrator.  It will need to check that the new database
>> has the same "default" settings (where "default" means "those of
>> template0") as the old installation did.  I think that's probably doable
>> but we'll have to check.

> I have already coded pg_migrator to get the 8.4 template0 locale  and
> check for a match of that against pg_controldata of 8.3.  Are you saying
> I need to spin through all the databases after they are created and
> check again?

No, that sounds like it should be sufficient ... but you need to check
the template0 encodings match too, assuming that we make encoding and
locale work the same here.
        regards, tom lane