Re: Minor binary-search int overflow in timezone code

Jim Nasby <Jim.Nasby@BlueTreble.com> writes:
> On 12/15/14, 1:39 PM, Christoph Berg wrote:
>> Well, if it's not interesting, let's just forget it. Sorry.

> At the risk of sticking my head in the lions mouth... this is the kind of response that deters people from
contributinganything to the project, including reviewing patches. A simple "thanks, but we feel it's already clear
enoughthat there can't be anywhere close to INT_MAX timezones" would have sufficed.
 

Yeah, I need to apologize.  I was a bit on edge today due to the release
wrap (which you may have noticed wasn't going too smoothly), and should
not have responded like that.

Having said that, though, the submission wasn't carefully thought through
either.  That problem was either not-an-issue or a potential security bug,
and if the submitter hadn't taken the time to be sure which, reporting it
in a public forum wasn't the way to proceed.

I also remain curious as to what sort of tool would complain about this
particular code and not the N other nearly-identical binary-search loops
in the PG sources, most of which deal with data structures potentially
far larger than the timezone data ...
        regards, tom lane